Messages in this thread | | | Date | Mon, 13 Mar 2023 09:49:41 +0200 | From | Matti Vaittinen <> | Subject | Re: [PATCHv1 06/11] power: supply: generic-adc-battery: drop charge now support |
| |
Hi dee Ho all,
On 3/10/23 10:29, Linus Walleij wrote: > On Thu, Mar 9, 2023 at 11:50 PM Sebastian Reichel <sre@kernel.org> wrote: > >> Drop CHARGE_NOW support, which requires a platform specific >> calculation method. >> >> Signed-off-by: Sebastian Reichel <sre@kernel.org> > > I agree. If we want to support this, we should use the generic > methods with interpolation tables defined in DT as well, and it also > ideally requires load compensated resistance calculation to figure > out Ri so this can bring any kind of reasonable precision.
I guess you have your reasons, besides you have far better insight to things than I do - hence I am not really objecting this - just asking a question ;)
Do we have generic facilities of computing this based on the DT tables / Ri in place(?) I guess that we do need/see platform specific implementations as long as there is no generic "de-facto" way of doing this available...
Well, maybe this helps kicking things to that direction :)
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
-- Matti
-- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
| |