Messages in this thread | | | Date | Mon, 13 Mar 2023 12:05:43 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v7 40/41] x86/shstk: Add ARCH_SHSTK_UNLOCK |
| |
On Mon, Mar 13, 2023 at 03:04:10AM +0000, Edgecombe, Rick P wrote: > This is how the other arch_prctl()s handle it (if they do handle it, > some don't). So I would think it would be nice to keep all the logic > the same. > > I guess the flag might work based on the assumption that if the task is > being ptraced, the arch_prctl() couldn't be coming from anywhere else. > Maybe it should get a nicely named helper that they could all use and > whatever best logic could be commented. > > Would this maybe be better as a future cleanup that did the change for > them all?
Yeah, I'm just being overly paranoid.
Because if there's another way to unlock that feature, then this whole "overhead" we're doing is for nothing.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |