Messages in this thread Patch in this message | | | Date | Mon, 13 Mar 2023 06:36:07 +0100 | From | Oleksij Rempel <> | Subject | Re: [PATCH net-next v3 2/2] net: dsa: microchip: add ETS Qdisc support for KSZ9477 series |
| |
On Mon, Mar 13, 2023 at 03:34:16AM +0000, Arun.Ramadoss@microchip.com wrote: > Hi Oleksij, > On Fri, 2023-03-10 at 10:08 +0100, Oleksij Rempel wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > know the content is safe > > > > Add ETS Qdisc support for KSZ9477 of switches. Current implementation > > is > > limited to strict priority mode. > > > > Tested on KSZ8563R with following configuration: > > tc qdisc replace dev lan2 root handle 1: ets strict 4 \ > > priomap 3 3 2 2 1 1 0 0 > > ip link add link lan2 name v1 type vlan id 1 \ > > egress-qos-map 0:0 1:1 2:2 3:3 4:4 5:5 6:6 7:7 > > > > and patched iperf3 version: > > https://github.com/esnet/iperf/pull/1476 > > iperf3 -c 172.17.0.1 -b100M -l1472 -t100 -u -R --sock-prio 2 > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > drivers/net/dsa/microchip/ksz_common.c | 218 > > +++++++++++++++++++++++++ > > drivers/net/dsa/microchip/ksz_common.h | 12 ++ > > 2 files changed, 230 insertions(+) > > > > diff --git a/drivers/net/dsa/microchip/ksz_common.c > > b/drivers/net/dsa/microchip/ksz_common.c > > index ae05fe0b0a81..54d75ec22ef0 100644 > > --- a/drivers/net/dsa/microchip/ksz_common.c > > +++ b/drivers/net/dsa/microchip/ksz_common.c > > @@ -1087,6 +1087,7 @@ const struct ksz_chip_data ksz_switch_chips[] = > > { > > .port_nirqs = 3, > > .num_tx_queues = 4, > > .tc_cbs_supported = true, > > + .tc_ets_supported = true, > > Whether the switch which are supporting cbs will also support ets or > not. If CBS and ETS are related, then is it possible to use single flag > controlling both the feature. I could infer that switch which has > tc_cbs_supported true, also has tc_ets_supported also true. > > If both are different, patch looks good to me.
Both are different. For example on ksz8 switches it is possible to implement tc-etc but not tc-cbs.
Regatds, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |