Messages in this thread | | | Date | Mon, 13 Mar 2023 11:20:16 +0200 | From | Heikki Krogerus <> | Subject | Re: [PATCH 2/2] usb: typec: fusb302: mark OF related data as maybe unused |
| |
On Fri, Mar 10, 2023 at 11:29:37PM +0100, Krzysztof Kozlowski wrote: > The driver can be compile tested with !CONFIG_OF making certain data > unused: > > drivers/usb/typec/tcpm/fusb302.c:1816:34: error: ‘fusb302_dt_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Should this be marked as a fix?
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> --- > drivers/usb/typec/tcpm/fusb302.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c > index 1ffce00d94b4..592b0aec782f 100644 > --- a/drivers/usb/typec/tcpm/fusb302.c > +++ b/drivers/usb/typec/tcpm/fusb302.c > @@ -1813,7 +1813,7 @@ static int fusb302_pm_resume(struct device *dev) > return 0; > } > > -static const struct of_device_id fusb302_dt_match[] = { > +static const struct of_device_id fusb302_dt_match[] __maybe_unused = { > {.compatible = "fcs,fusb302"}, > {}, > }; > -- > 2.34.1
-- heikki
| |