Messages in this thread | | | Date | Mon, 13 Mar 2023 09:23:43 +0800 | Subject | Re: [PATCH 2/2] serial: sprd: Drop of_match_ptr for ID table | From | Baolin Wang <> |
| |
On 3/11/2023 6:29 AM, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it is not relevant here). > > drivers/tty/serial/sprd_serial.c:1242:34: error: ‘serial_ids’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
LGTM. Thanks. Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> --- > drivers/tty/serial/sprd_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c > index 492a3bdab5ba..b58f51296ace 100644 > --- a/drivers/tty/serial/sprd_serial.c > +++ b/drivers/tty/serial/sprd_serial.c > @@ -1250,7 +1250,7 @@ static struct platform_driver sprd_platform_driver = { > .remove = sprd_remove, > .driver = { > .name = "sprd_serial", > - .of_match_table = of_match_ptr(serial_ids), > + .of_match_table = serial_ids, > .pm = &sprd_pm_ops, > }, > };
| |