lkml.org 
[lkml]   [2023]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] staging: greybus: Fix Alignment with parenthesis
From

On ١١‏/٣‏/٢٠٢٣ ١٠:٥٩, Julia Lawall wrote:
>
> On Fri, 10 Mar 2023, Menna Mahmoud wrote:
>
>> Fix " CHECK: Alignment should match open parenthesis "
>> Reported by checkpath
> See the message in the other mail about the log message.
>
> Also, you should not have two patches with the same subject. Here, the
> changes are on the same file and are essentially the same, even involving
> the same function call. So they can be together in one patch.
>
> julia
okay, I will. appreciate your feedback. thanks.
>
>> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
>> ---
>> drivers/staging/greybus/fw-core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c
>> index 57bebf24636b..f562cb12d5ad 100644
>> --- a/drivers/staging/greybus/fw-core.c
>> +++ b/drivers/staging/greybus/fw-core.c
>> @@ -89,7 +89,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle,
>> }
>>
>> connection = gb_connection_create(bundle, cport_id,
>> - gb_fw_mgmt_request_handler);
>> + gb_fw_mgmt_request_handler);
>> if (IS_ERR(connection)) {
>> ret = PTR_ERR(connection);
>> dev_err(&bundle->dev,
>> --
>> 2.34.1
>>
>>
>>

\
 
 \ /
  Last update: 2023-03-27 00:54    [W:0.147 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site