lkml.org 
[lkml]   [2023]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v5 1/1] net: dsa: hellcreek: Get rid of custom led_init_default_state_get()
On Fri, Mar 10, 2023 at 08:44:04PM +0200, Andy Shevchenko wrote:
> On Fri, Mar 10, 2023 at 07:18:42PM +0100, Simon Horman wrote:
> > On Fri, Mar 10, 2023 at 06:38:55PM +0200, Andy Shevchenko wrote:
>
> ...
>
> > > + hellcreek->led_sync_good.brightness =
> > > + hellcreek_get_brightness(hellcreek, STATUS_OUT_SYNC_GOOD);
> >
> > nit: I think < 80 columns wide is still preferred for network code
>
> I can do it if it's a strict rule here.

I think it is more a preference than a strict rule at this point.

\
 
 \ /
  Last update: 2023-03-27 00:53    [W:0.156 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site