Messages in this thread | | | Date | Fri, 10 Mar 2023 20:44:04 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH net-next v5 1/1] net: dsa: hellcreek: Get rid of custom led_init_default_state_get() |
| |
On Fri, Mar 10, 2023 at 07:18:42PM +0100, Simon Horman wrote: > On Fri, Mar 10, 2023 at 06:38:55PM +0200, Andy Shevchenko wrote:
...
> > + hellcreek->led_sync_good.brightness = > > + hellcreek_get_brightness(hellcreek, STATUS_OUT_SYNC_GOOD); > > nit: I think < 80 columns wide is still preferred for network code
I can do it if it's a strict rule here.
...
> This seems to duplicate the logic in the earlier hunk of this patch. > Could it be moved into a helper?
It's possible, but in a separate patch as it's out of scope of this one. Do you want to create a such?
-- With Best Regards, Andy Shevchenko
| |