Messages in this thread | | | From | "Edgecombe, Rick P" <> | Subject | Re: [PATCH v7 08/41] x86/shstk: Add user control-protection fault handler | Date | Wed, 1 Mar 2023 18:14:44 +0000 |
| |
On Wed, 2023-03-01 at 19:06 +0100, Borislav Petkov wrote: > On Mon, Feb 27, 2023 at 02:29:24PM -0800, Rick Edgecombe wrote: > > diff --git a/arch/x86/kernel/cet.c b/arch/x86/kernel/cet.c > > index 7ad22b705b64..cc10d8be9d74 100644 > > --- a/arch/x86/kernel/cet.c > > +++ b/arch/x86/kernel/cet.c > > @@ -4,10 +4,6 @@ > > #include <asm/bugs.h> > > #include <asm/traps.h> > > > > -static __ro_after_init bool ibt_fatal = true; > > - > > -extern void ibt_selftest_ip(void); /* code label defined in asm > > below */ > > - > > enum cp_error_code { > > CP_EC = (1 << 15) - 1, > > From a previous review: > > "That looks like a mask, so > > CP_EC_MASK > > I guess."
It is from the existing code:
https://lore.kernel.org/lkml/393a03d063dee5831af93ca67636df75a76481c3.camel@intel.com/#t
The rename certainly doesn't belong in the code move patch, but I took the previous discussion to mean it didn't belong in this patch either. Do you want me to add it to this one or a separate one?
| |