lkml.org 
[lkml]   [2023]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 3/6] zsmalloc: fine-grained inuse ratio based fullness grouping
On (23/02/28 14:53), Minchan Kim wrote:
> BTW, I still prefer the enum instead of 10 define.
>
> enum fullness_group {
> ZS_EMPTY,
> ZS_INUSE_RATIO_MIN,
> ZS_INUSE_RATIO_ALMOST_FULL = 7,
> ZS_INUSE_RATIO_MAX = 10,
> ZS_FULL,
> NR_ZS_FULLNESS,
> }

For educational purposes, may I ask what do enums give us? We
always use integers - int:4 in zspage fullness, int for arrays
offsets and we cast to plain integers in get/set stats. So those
enums exist only at declaration point, and plain int otherwise.
What are the benefits over #defines?

\
 
 \ /
  Last update: 2023-03-27 00:39    [W:0.322 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site