lkml.org 
[lkml]   [2023]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 17/22] rtc: pm8xxx: add support for nvmem offset
    On Mon, Feb 06, 2023 at 07:16:54PM -0800, David Collins wrote:
    > On 2/2/23 07:54, Johan Hovold wrote:

    > > +static int pm8xxx_rtc_read_nvmem_offset(struct pm8xxx_rtc *rtc_dd)
    > > +{
    > > + size_t len;
    > > + void *buf;
    > > + int rc;
    > > +
    > > + buf = nvmem_cell_read(rtc_dd->nvmem_cell, &len);
    > > + if (IS_ERR(buf)) {
    > > + rc = PTR_ERR(buf);
    > > + dev_dbg(rtc_dd->dev, "failed to read nvmem offset: %d\n", rc);
    >
    > Why is dev_dbg() used instead of dev_err() for newly added error
    > messages? Also, why do these conditions warrant error logging when some
    > of the previous patches in this series removed older error logging?

    I would have used dev_err() here and did so for v1, but Alexandre
    prefers dev_dbg() for errors that are unlikely to be seen by regular
    users but that can still be useful to developers (e.g. when enabling the
    rtc on a new platform).

    One or two of the spmi errors I removed falls in the same category in so
    far that the control and time registers may write-protected on some
    platforms, but such errors are currently logged by the spmi controller
    driver.

    Johan

    \
     
     \ /
      Last update: 2023-03-27 00:12    [W:4.105 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site