Messages in this thread | | | Date | Tue, 7 Feb 2023 12:53:40 +0100 | From | Pavel Machek <> | Subject | Re: API for setting colors of RGB backlit keyboard zones (was [PATCH V3] platform/x86: hp-wmi: Support omen backlight control wmi-acpi methods) |
| |
Hi!
> >> 2. Create 4 separate multi-color LED sysfs devices for each zone: > >> > >> /sys/class/leds/hp_omen::kbd_backlight-zone1/ > >> /sys/class/leds/hp_omen::kbd_backlight-zone2/ > >> /sys/class/leds/hp_omen::kbd_backlight-zone3/ > >> /sys/class/leds/hp_omen::kbd_backlight-zone4/
4 separate devices, please. And the naming should be consistent with the rest, so
:rbg:kbd_backlight-zone1
would be closer to something consistent. Should be documented in
Documentation/leds/well-known-leds.txt
. And if you take a look there, you'll notice we already have N900 that has 6 zones with white backlight.
But I'd really like to see plan to go forward. AFAICT there are keyboards with per-key backlight, and those start to look less like a set of LEDs and more like a display...
Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates. [unhandled content-type:application/pgp-signature] | |