Messages in this thread | | | Date | Tue, 7 Feb 2023 12:51:44 +0100 | Subject | Re: [PATCH v1 16/45] clk: mediatek: mt8167: Convert to mtk_clk_simple_{probe,remove}() | From | AngeloGioacchino Del Regno <> |
| |
Il 07/02/23 09:07, Chen-Yu Tsai ha scritto: > On Mon, Feb 6, 2023 at 11:30 PM AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> wrote: >> >> Convert topckgen and infracfg clock drivers to use the common >> mtk_clk_simple_probe() mechanism and change this from the old >> "static" CLK_OF_DECLARE to be a platform driver, allowing it >> to eventually be built as a module. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > Code looks OK, but vdecsys converted to builtin_platform_driver() while > the others to module_platform_driver(). This deserves an explanation. >
There's nothing to be explained, other than this being a big overlook... :-P
Fixed that for v2, vdec deserves the module_platform_driver() treatment too!
Cheers, Angelo
| |