Messages in this thread | | | From | Balsam CHIHI <> | Date | Mon, 6 Feb 2023 15:32:51 +0100 | Subject | Re: [PATCH v12] thermal: drivers: mediatek: Add the Low Voltage Thermal Sensor driver |
| |
Hi Daniel,
On Mon, Feb 6, 2023 at 3:07 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > On Wed, Feb 01, 2023 at 08:55:07AM +0100, Krzysztof Kozlowski wrote: > > On 31/01/2023 16:38, bchihi@baylibre.com wrote: > > > From: Balsam CHIHI <bchihi@baylibre.com> > > > > > > The Low Voltage Thermal Sensor (LVTS) is a multiple sensors, multi > > > controllers contained in a thermal domain. > > > > > > A thermal domains can be the MCU or the AP. > > > > > > Each thermal domains contain up to seven controllers, each thermal > > > controller handle up to four thermal sensors. > > > > > > The LVTS has two Finite State Machines (FSM), one to handle the > > > functionin temperatures range like hot or cold temperature and another > > > one to handle monitoring trip point. The FSM notifies via interrupts > > > when a trip point is crossed. > > > > > > > (...) > > > > > + > > > +struct lvts_domain { > > > + struct lvts_ctrl *lvts_ctrl; > > > + struct reset_control *reset; > > > + struct clk *clk; > > > + int num_lvts_ctrl; > > > + void __iomem *base; > > > + size_t calib_len; > > > + u8 *calib; > > > +}; > > > + > > > +#ifdef CONFIG_MTK_LVTS_THERMAL_DEBUGFS > > > + > > > +static struct dentry *root; > > > > How do you handle two instances of driver? > > For now, we can put the entry in /sys/kernel/debug/<dev_name>
Yes, sure. I will do the necessary changes.
> > I'm preparing a debugfs series for the thermal framework and that will provide > an entry to hook in for the sensors debugfs if available
It would be a good feature! good luck!
Best regards, Balsam.
| |