lkml.org 
[lkml]   [2023]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RESEND PATCH 35/37] nvmem: qcom-spmi-sdam: register at device init time
    Date
    From: Johan Hovold <johan+linaro@kernel.org>

    There are currently no in-tree users of the Qualcomm SDAM nvmem driver
    and there is generally no point in registering a driver that can be
    built as a module at subsys init time.

    Register the driver at the normal device init time instead and let
    driver core sort out the probe order.

    Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
    Reviewed-by: Bjorn Andersson <andersson@kernel.org>
    Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    ---
    drivers/nvmem/qcom-spmi-sdam.c | 13 +------------
    1 file changed, 1 insertion(+), 12 deletions(-)

    diff --git a/drivers/nvmem/qcom-spmi-sdam.c b/drivers/nvmem/qcom-spmi-sdam.c
    index 8499892044b7..f822790db49e 100644
    --- a/drivers/nvmem/qcom-spmi-sdam.c
    +++ b/drivers/nvmem/qcom-spmi-sdam.c
    @@ -175,18 +175,7 @@ static struct platform_driver sdam_driver = {
    },
    .probe = sdam_probe,
    };
    -
    -static int __init sdam_init(void)
    -{
    - return platform_driver_register(&sdam_driver);
    -}
    -subsys_initcall(sdam_init);
    -
    -static void __exit sdam_exit(void)
    -{
    - return platform_driver_unregister(&sdam_driver);
    -}
    -module_exit(sdam_exit);
    +module_platform_driver(sdam_driver);

    MODULE_DESCRIPTION("QCOM SPMI SDAM driver");
    MODULE_LICENSE("GPL v2");
    --
    2.25.1
    \
     
     \ /
      Last update: 2023-03-27 00:10    [W:8.721 / U:0.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site