lkml.org 
[lkml]   [2023]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v4 00/23] net: add EEE support for KSZ9477 and AR8035 with i.MX6
    On Sat, Feb 04, 2023 at 02:13:32AM +0200, Vladimir Oltean wrote:
    > On Wed, Feb 01, 2023 at 03:58:22PM +0100, Oleksij Rempel wrote:
    > > With this patch series we provide EEE control for KSZ9477 family of switches and
    > > AR8035 with i.MX6 configuration.
    > > According to my tests, on a system with KSZ8563 switch and 100Mbit idle link,
    > > we consume 0,192W less power per port if EEE is enabled.
    >
    > What is the code flow through the kernel with EEE? I wasn't able to find
    > a good explanation about it.
    >
    > Is it advertised by default, if supported? I guess phy_advertise_supported()
    > does that.

    Ack.

    > But is that desirable? Doesn't EEE cause undesired latency for MAC-level
    > PTP timestamping on an otherwise idle link?

    Theoretically, MAC controls Low Power Idle states and even with some
    "Wake" latency should be fully aware of actual ingress and egress time
    stamps.

    Practically, right now I do not have such HW to confirm it. My project
    is affected by EEE in different ways:
    - with EEE PTP has too much jitter
    - without EEE, the devices consumes too much power in standby mode with
    WoL enabled. Even switching to 10BaseT less power as 100BaseTX with
    EEE would do.

    My view is probably biased by my environment - PTP is relatively rare
    use case. EEE saves power (0,2W+0,2W per link in my case). Summary power
    saving of all devices is potentially equal to X amount of power plants.
    So, EEE should be enabled by default.

    Beside, flow control (enabled by default) affects PTP in some cases too.

    May be ptp4l should warn about this options? We should be able to detect
    it from user space.

    Regards,
    Oleksij
    --
    Pengutronix e.K. | |
    Steuerwalder Str. 21 | http://www.pengutronix.de/ |
    31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

    \
     
     \ /
      Last update: 2023-03-27 00:10    [W:3.027 / U:0.448 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site