Messages in this thread | | | Date | Mon, 6 Feb 2023 21:21:39 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v4 00/23] net: add EEE support for KSZ9477 and AR8035 with i.MX6 |
| |
> SmartEEE will be probably a bit more challenging. If MAC do not > advertise EEE support, SmartEEE can be enabled. But it would break PTP > if SmartEEE is active. Except SmartEEE capable PHY implements own PTP > support. In any case, user space will need extra information to > identify potential issues.
If we have a MAC driver which does not implement the ethtool set_eee() and get_eee() ops, and a dev->phydev with the SmartEEE flag set, we could have net/ethtool/eee.c call direct into phylib.
As for PTP and EEE, maybe we want the core PTP code to try calling get_eee() and at minimum issue a warning if it is enabled, if it thinks MAC PTP is being used?
Andrew
| |