lkml.org 
[lkml]   [2023]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] TTY/Serial driver fixes for 6.2-rc7
On Sun, Feb 05, 2023 at 12:17:05PM -0800, Linus Torvalds wrote:
> On Sun, Feb 5, 2023 at 3:53 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > George Kennedy (1):
> > vc_screen: move load of struct vc_data pointer in vcs_read() to avoid UAF
>
> Hmm.
>
> I think the "goto unlock_out" should be a "break". A partial read
> should return the partial success, not an error.
>
> That situation didn't exist when the check was outside the loop, but does now.
>
> Now, I don't think this matters for any sane situation, but since I
> looked at this patch I thought I'd mention it.

Fair enough, George, can you send a follow-on patch to fix this up?

thanks,

greg k-h

\
 
 \ /
  Last update: 2023-03-27 00:10    [W:0.076 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site