Messages in this thread Patch in this message | | | From | k1rh4.lee@gmail ... | Subject | [PATCH] fpga: dfl-afu-region: Add overflow checks for region size and offset | Date | Sun, 5 Feb 2023 21:43:26 -0800 |
| |
From: Sangsup Lee <k1rh4.lee@gmail.com>
The size + offset is able to be integer overflow value and it lead to mis-allocate region.
Signed-off-by: Sangsup Lee <k1rh4.lee@gmail.com> --- drivers/fpga/dfl-afu-region.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/fpga/dfl-afu-region.c b/drivers/fpga/dfl-afu-region.c index 2e7b41629406..82b530111601 100644 --- a/drivers/fpga/dfl-afu-region.c +++ b/drivers/fpga/dfl-afu-region.c @@ -151,12 +151,17 @@ int afu_mmio_region_get_by_offset(struct dfl_feature_platform_data *pdata, struct dfl_afu_mmio_region *region; struct dfl_afu *afu; int ret = 0; + u64 region_size = 0; mutex_lock(&pdata->lock); + if (check_add_overflow(offset, size, ®ion_size)) { + ret = -EINVAL; + goto exit; + } afu = dfl_fpga_pdata_get_private(pdata); for_each_region(region, afu) if (region->offset <= offset && - region->offset + region->size >= offset + size) { + region->offset + region->size >= region_size) { *pregion = *region; goto exit; } -- 2.25.1
| |