Messages in this thread | | | Date | Sat, 4 Feb 2023 02:14:56 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next v4 01/23] net: dsa: microchip: enable EEE support |
| |
On Wed, Feb 01, 2023 at 03:58:23PM +0100, Oleksij Rempel wrote: > +static int ksz_get_mac_eee(struct dsa_switch *ds, int port, > + struct ethtool_eee *e) > +{ > + int ret; > + > + ret = ksz_validate_eee(ds, port); > + if (ret) > + return ret; > + > + /* There is no documented control of Tx LPI configuration. > + */
comment fits on a single line
> + e->tx_lpi_enabled = true; > + /* There is no documented control of Tx LPI timer. According to testes
according to tests, I hope, not testes
> + * Tx LPI timer seems to be set by default to minimal value. > + */ > + e->tx_lpi_timer = 0; > + > + return 0; > +}
| |