lkml.org 
[lkml]   [2023]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mtd: ubi: eba.c: fix return value overwrite issue in try_write_vid_and_data()
On Sat, Feb 18, 2023 at 12:58:08AM +0800, Wang YanQing wrote:
> The commit 2d78aee426d8 ("UBI: simplify LEB write and atomic LEB change code")
> adds helper function, try_write_vid_and_data(), to simplify the code, but this
> helper function has bug, it will return 0 (success) when ubi_io_write_vid_hdr()
> or the ubi_io_write_data() return error number (-EIO, etc), because the return
> value of ubi_wl_put_peb() will overwrite the original return value.
>
> This issue will cause unexpected data loss issue, because the caller of this
> function and UBIFS willn't know the data is lost.
>
> Fixes: 2d78aee426d8 ("UBI: simplify LEB write and atomic LEB change code")
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>

Hi! Miquel Raynal

What is the status about this patch?

Thanks!

\
 
 \ /
  Last update: 2023-03-27 00:35    [W:0.062 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site