Messages in this thread | | | From | Miguel Ojeda <> | Date | Sun, 26 Feb 2023 14:56:07 +0100 | Subject | Re: [PATCH 2/5] rust: error: Add Error::from_kernel_errno() |
| |
On Sat, Feb 25, 2023 at 11:19 PM Gary Guo <gary@garyguo.net> wrote: > > Maybe just `from_errno`? I don't know why `kernel` would need to be > emphasised here.
Yeah, that sounds good to me. It is clear and we don't use "errno" elsewhere. This identifier came from the original import, so before we started to think about naming policies.
Though perhaps we can clean it up in a patch later, since we should change `to_kernel_errno` below too at the same time. Or if you want to send a quick patch for that one, I can put it in first.
Cheers, Miguel
| |