Messages in this thread | | | Date | Thu, 23 Feb 2023 17:17:26 +0800 | Subject | Re: [PATCH 1/2] Mips: ls2k1000: dts: add the display controller device node | From | suijingfeng <> |
| |
On 2023/2/23 16:59, Krzysztof Kozlowski wrote: > On 23/02/2023 09:40, suijingfeng wrote: >> On 2023/2/23 15:58, Krzysztof Kozlowski wrote: >>> On 23/02/2023 04:19, Sui jingfeng wrote: >>>> Hi, >>>> >>>> On 2023/2/23 02:32, Krzysztof Kozlowski wrote: >>>>> On 22/02/2023 17:55, suijingfeng wrote: >>>>>> The display controller is a pci device, it's pci vendor id is >>>>>> 0x0014, it's pci device id is 0x7a06. >>>>>> >>>>>> Signed-off-by: suijingfeng <suijingfeng@loongson.cn> >>>>>> --- >>>>>> .../boot/dts/loongson/loongson64-2k1000.dtsi | 21 +++++++++++++++++++ >>>>>> 1 file changed, 21 insertions(+) >>>>>> >>>>>> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi >>>>>> index 8143a61111e3..a528af3977d9 100644 >>>>>> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi >>>>>> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi >>>>>> @@ -31,6 +31,18 @@ memory@200000 { >>>>>> <0x00000001 0x10000000 0x00000001 0xb0000000>; /* 6912 MB at 4352MB */ >>>>>> }; >>>>>> >>>>>> + reserved-memory { >>>>>> + #address-cells = <2>; >>>>>> + #size-cells = <2>; >>>>>> + ranges; >>>>>> + >>>>>> + display_reserved: framebuffer@30000000 { >>>>>> + compatible = "shared-dma-pool"; >>>>>> + reg = <0x0 0x30000000 0x0 0x04000000>; /* 64M */ >>>>>> + linux,cma-default; >>>>>> + }; >>>>>> + }; >>>>>> + >>>>>> cpu_clk: cpu_clk { >>>>>> #clock-cells = <0>; >>>>>> compatible = "fixed-clock"; >>>>>> @@ -198,6 +210,15 @@ sata@8,0 { >>>>>> interrupt-parent = <&liointc0>; >>>>>> }; >>>>>> >>>>>> + display-controller@6,0 { >>>>>> + compatible = "loongson,ls2k1000-dc"; >>>>>> + >>>>>> + reg = <0x3000 0x0 0x0 0x0 0x0>; >>>>>> + interrupts = <28 IRQ_TYPE_LEVEL_LOW>; >>>>>> + interrupt-parent = <&liointc0>; >>>>>> + memory-region = <&display_reserved>; >>>>> NAK. >>>> Err :(, please give me a chance to explain >>>>> Test your code against the bindings you send. >>>> I can guarantee to you that I test may code more than twice. The code >>>> used to testing is listed at link [1]. >>> I wrote - test against the bindings. I don't believe that it was tested. >>> Please paste the output of the testing (dtbs_check). > ^^^^^^^^^^^^ > Do you see this ----------^^^^? > > But you pasted: > >> I *do* run the test against the bindings and the test result say nothing. >> >> I reset my modify today made, then re-run the test again. >> >> I'm telling the truth: the test result say nothing. I paste the log at >> below: >> >> make -j$(nproc) ARCH=loongarch >> CROSS_COMPILE=loongarch64-unknown-linux-gnu- dt_binding_check > This -------------------------------------------^^^^^^^^^^^^
Yes, I see it.
I means I have tested all of them as the instruction[1]!
the test log just say nothing. I re-run it again and all passed.
[1] https://www.kernel.org/doc/html/v5.9/devicetree/writing-schema.html#:~:text=The%20DT%20schema%20project%20can%20be%20installed%20with,they%20are%20in%20your%20PATH%20%28~%2F.local%2Fbin%20by%20default%29.
> > Best regards, > Krzysztof
| |