Messages in this thread | | | Date | Wed, 22 Feb 2023 21:00:05 +0100 | Subject | Re: [PATCH v2 06/16] thermal: Don't use 'device' internal thermal zone structure field | From | Daniel Lezcano <> |
| |
On 22/02/2023 20:43, Rafael J. Wysocki wrote: > On Tue, Feb 21, 2023 at 7:07 PM Daniel Lezcano > <daniel.lezcano@linaro.org> wrote: >> >> Some drivers are directly using the thermal zone's 'device' structure >> field. >> >> Use the driver device pointer instead of the thermal zone device when >> it is available. >> >> Remove the traces when they are duplicate with the traces in the core >> code. >> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >> Reviewed-by: Balsam CHIHI <bchihi@baylibre.com> #Mediatek LVTS >> ---
[ ... ]
>> thermal_zone_device_update(data->ti_thermal, THERMAL_EVENT_UNSPECIFIED); >> >> - dev_dbg(&data->ti_thermal->device, "updated thermal zone %s\n", >> + dev_dbg(data->bgp->dev, "updated thermal zone %s\n", >> data->ti_thermal->type); > > The code before the change is more consistent, because it refers to > the same object in both instances. > > It looks like a type field accessor is needed, eg. thermal_zone_device_type()? > > Or move the debug message to thermal_zone_device_update()?
Actually it is done on purpose because the patch 9 replaces the accesses to 'type' by 'id', the thermal_zone_device_type() accessor won't be needed.
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |