Messages in this thread | | | Date | Wed, 22 Feb 2023 11:31:12 -0800 | From | David Matlack <> | Subject | Re: [Patch v3 5/7] KVM: x86/mmu: Remove "record_acc_track" in __tdp_mmu_set_spte() |
| |
On Fri, Feb 10, 2023 at 05:46:24PM -0800, Vipin Sharma wrote: > Remove bool parameter "record_acc_track" from __tdp_mmu_set_spte() and > refactor the code. This variable is always set to true by its caller. > > Remove single and double underscore prefix from tdp_mmu_set_spte()
uber-nit: I find it helpful to use phrasing like "Opportunistically do X" for opportunistic cleanups that are separate from the primary change. Otherwise the commit message reads as if 2 totally independent changes are being made.
> related APIs: > 1. Change __tdp_mmu_set_spte() to tdp_mmu_set_spte() > 2. Change _tdp_mmu_set_spte() to tdp_mmu_iter_set_spte() > > Signed-off-by: Vipin Sharma <vipinsh@google.com> > ---
Reviewed-by: David Matlack <dmatlack@google.com>
| |