Messages in this thread | | | Date | Wed, 22 Feb 2023 15:40:48 +0100 | Subject | Re: [PATCH] soundwire: qcom: correct setting ignore bit on v1.5.1 | From | Konrad Dybcio <> |
| |
On 22.02.2023 15:03, Krzysztof Kozlowski wrote: > According to the comment and to downstream sources, the > SWRM_CONTINUE_EXEC_ON_CMD_IGNORE in SWRM_CMD_FIFO_CFG_ADDR register > should be set for v1.5.1 and newer, so fix the >= operator. > > Fixes: 542d3491cdd7 ("soundwire: qcom: set continue execution flag for ignored commands") > Cc: <stable@vger.kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad > drivers/soundwire/qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index d5b73b7f98bf..29035cf15407 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -733,7 +733,7 @@ static int qcom_swrm_init(struct qcom_swrm_ctrl *ctrl) > } > > /* Configure number of retries of a read/write cmd */ > - if (ctrl->version > 0x01050001) { > + if (ctrl->version >= 0x01050001) { > /* Only for versions >= 1.5.1 */ > ctrl->reg_write(ctrl, SWRM_CMD_FIFO_CFG_ADDR, > SWRM_RD_WR_CMD_RETRIES |
| |