Messages in this thread | | | Date | Wed, 22 Feb 2023 16:15:49 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v10 0/8] i2c-atr and FPDLink |
| |
On Wed, Feb 22, 2023 at 03:28:59PM +0200, Tomi Valkeinen wrote: > Hi, > > You can find v9 from: > > https://lore.kernel.org/all/20230216140747.445477-1-tomi.valkeinen@ideasonboard.com/ > > Diff to v9 included below. > > Main changes in v10: > - Switch pre-increments to post-increments > - Add macros for FPD3_RX_ID lengths > - Use regmap_bulk_read in 16 bit reg accessors
Thanks! I have no more remarks, nice job!
One thing below to just look at and if you want / have time / chance update.
...
> + ret = regmap_bulk_read(priv->regmap, reg, &__v, 2);
sizeof()
...
> + ret = regmap_bulk_read(priv->regmap, reg, &__v, 2);
Ditto.
-- With Best Regards, Andy Shevchenko
| |