Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] wifi: ath11k: fix SAC bug on peer addition with sta band migration | Date | Wed, 22 Feb 2023 12:07:29 +0200 |
| |
Christian Marangi <ansuelsmth@gmail.com> writes:
> On Mon, Feb 20, 2023 at 08:57:51AM +0000, Kalle Valo wrote: >> Christian Marangi <ansuelsmth@gmail.com> wrote: >> >> > Fix sleep in atomic context warning detected by Smatch static checker >> > analyzer. >> > >> > Following the locking pattern for peer_rhash_add lock tbl_mtx_lock mutex >> > always even if sta is not transitioning to another band. >> > This is peer_add function and a more secure locking should not cause >> > performance regression. >> > >> > Fixes: d673cb6fe6c0 ("wifi: ath11k: fix peer addition/deletion >> > error on sta band migration") >> > Reported-by: Dan Carpenter <error27@gmail.com> >> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> >> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> >> >> I assume you only compile tested this and I'll add that to the commit log. It's >> always good to know how the patch was tested. >> > > Hi, I just got time to test this and works correctly on my Xiaomi > AX3600. > > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01208-QCAHKSWPL_SILICONZ-1
Thanks, I'll add this to the commit log.
-- https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |