Messages in this thread | | | Date | Tue, 21 Feb 2023 21:37:21 -0800 | From | Randy Dunlap <> | Subject | Alpha MTD_TSUNAMI BROKEN? |
| |
Hi,
In an alpha kernel config with CONFIG_ALPHA_TSUNAMI=y and CONFIG_MTD_TSUNAMI=y, the MTD driver build fails with:
../drivers/mtd/maps/tsunami_flash.c: In function 'tsunami_flash_read8': ../drivers/mtd/maps/tsunami_flash.c:21:20: error: implicit declaration of function 'tsunami_tig_readb'; did you mean 'tsunami_readb'? [-Werror=implicit-function-declaration] 21 | val.x[0] = tsunami_tig_readb(offset); | ^~~~~~~~~~~~~~~~~ | tsunami_readb ../drivers/mtd/maps/tsunami_flash.c: In function 'tsunami_flash_write8': ../drivers/mtd/maps/tsunami_flash.c:27:9: error: implicit declaration of function 'tsunami_tig_writeb'; did you mean 'tsunami_writeb'? [-Werror=implicit-function-declaration] 27 | tsunami_tig_writeb(value.x[0], offset); | ^~~~~~~~~~~~~~~~~~ | tsunami_writeb
The tsunami_tig_{readb,writeb{}() functions are completely missing. I don't see any macros that would generate such function names.
I have searched both kernel/git/history/history.git and kernel/git/mpe/linux-fullhistory.git (both at git.kernel.org) and found no such functions. (It's possible that I could have missed something here: all I did was 'git grep tsunami_tig'. Do I need to do 'git checkout <something really old>' first?)
Should these functions just be tsunami_readb() and tsunami_writeb() like the compiler asks? Or should we mark this driver as BROKEN?
Thanks. -- ~Randy
| |