Messages in this thread | | | Date | Wed, 22 Feb 2023 11:09:13 +0530 | Subject | Re: [PATCH V3 3/8] soundwire: amd: register SoundWire manager dai ops | From | "Mukunda,Vijendar" <> |
| |
On 22/02/23 05:18, Pierre-Louis Bossart wrote: > > On 2/21/23 16:05, Mukunda,Vijendar wrote: >> On 21/02/23 21:29, Pierre-Louis Bossart wrote: >>> >>>> +static const struct snd_soc_dai_ops amd_sdw_dai_ops = { >>>> + .hw_params = amd_sdw_hw_params, >>> don't you need a .prepare to deal with suspend-resume? >> DSP based solution is not implemented yet. >> As per our understanding In .prepare () callback, there is >> no extra logic needs to be implemented. Because of it, >> we have dropped .prepare() callback. > You don't need any logic IF the IP keeps its context while suspended. > That wasn't the case for us, we had to re-program the registers when > resuming. In our case, IP keeps its context while suspend. No need to implement .prepare() callback.
| |