Messages in this thread | | | From | Ryan Chen <> | Subject | RE: [PATCH v5 0/2] Add ASPEED AST2600 I2Cv2 controller driver | Date | Mon, 20 Feb 2023 09:56:04 +0000 |
| |
Hello Krzysztof,
Ryan Chen
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Monday, February 20, 2023 4:30 PM > To: Ryan Chen <ryan_chen@aspeedtech.com>; Rob Herring > <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; Andrew > Jeffery <andrew@aj.id.au>; Philipp Zabel <p.zabel@pengutronix.de>; > openbmc@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v5 0/2] Add ASPEED AST2600 I2Cv2 controller driver > > > On 20/02/2023 07:17, Ryan Chen wrote: > > This series add AST2600 i2cv2 new register set driver. The i2cv2 new > > register set have new clock divider option for more flexiable generation. > > Typo: flexible Will fix typo. > > > And also have separate i2c master and slave register set for control. > > Since several of my questions remained unanswered and quite frankly it's > fruitless... so let me read the commit msg directly - it's the same device, just > with different register layout. Having new compatible makes sense, but this > should be part of old binding. > Sorry, I am confused, Do you mean I should base on original Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml Add new compatible? Not add another aspeed,i2cv2.yaml.
Best regards, Ryan
| |