lkml.org 
[lkml]   [2023]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH v11 0/8] Use copy_process in vhost layer
    Date
    The following patches were made over Linus's tree. They allow the vhost
    layer to use copy_process instead of using workqueue_structs to create
    worker threads for VM's devices.

    Eric, the vhost maintainer, Michael Tsirkin has ACK'd the patches, so
    we are just waiting on you. I haven't got any more comments after several
    postings, and the last reply from you was a year ago on Jan 8th *2022*.
    Are you ok with these patches and can we merge them?

    Details:
    Qemu will create vhost devices in the kernel which perform network or SCSI,
    IO and perform management operations from worker threads created with the
    kthread API. Because the kthread API does a copy_process on the kthreadd
    thread, the vhost layer has to use kthread_use_mm to access the Qemu
    thread's memory and cgroup_attach_task_all to add itself to the Qemu
    thread's cgroups.

    The patches allow the vhost layer to do a copy_process from the thread that
    does the VHOST_SET_OWNER ioctl like how io_uring does a copy_process against
    its userspace thread. This allows the vhost layer's worker threads to inherit
    cgroups, namespaces, address space, etc. This worker thread will also be
    accounted for against that owner/parent process's RLIMIT_NPROC limit which
    will prevent malicious users from creating VMs with almost unlimited threads
    when these patches are used:

    https://lore.kernel.org/all/20211207025117.23551-1-michael.christie@oracle.com/

    which allow us to create a worker thread per N virtqueues.

    V11:
    - Rebase.
    V10:
    - Eric's cleanup patches and my vhost flush cleanup patches are merged
    upstream, so rebase against Linus's tree which has everything.
    V9:
    - Rebase against Eric's kthread-cleanups-for-v5.19 branch. Drop patches
    no longer needed due to kernel clone arg and pf io worker patches in that
    branch.
    V8:
    - Fix kzalloc GFP use.
    - Fix email subject version number.
    V7:
    - Drop generic user_worker_* helpers and replace with vhost_task specific
    ones.
    - Drop autoreap patch. Use kernel_wait4 instead.
    - Fix issue where vhost.ko could be removed while the worker function is
    still running.
    V6:
    - Rename kernel_worker to user_worker and fix prefixes.
    - Add better patch descriptions.
    V5:
    - Handle kbuild errors by building patchset against current kernel that
    has all deps merged. Also add patch to remove create_io_thread code as
    it's not used anymore.
    - Rebase patchset against current kernel and handle a new vm PF_IO_WORKER
    case added in 5.16-rc1.
    - Add PF_USER_WORKER flag so we can check it later after the initial
    thread creation for the wake up, vm and singal cses.
    - Added patch to auto reap the worker thread.
    V4:
    - Drop NO_SIG patch and replaced with Christian's SIG_IGN patch.
    - Merged Christian's kernel_worker_flags_valid helpers into patch 5 that
    added the new kernel worker functions.
    - Fixed extra "i" issue.
    - Added PF_USER_WORKER flag and added check that kernel_worker_start users
    had that flag set. Also dropped patches that passed worker flags to
    copy_thread and replaced with PF_USER_WORKER check.
    V3:
    - Add parentheses in p->flag and work_flags check in copy_thread.
    - Fix check in arm/arm64 which was doing the reverse of other archs
    where it did likely(!flags) instead of unlikely(flags).
    V2:
    - Rename kernel_copy_process to kernel_worker.




    \
     
     \ /
      Last update: 2023-03-27 00:08    [W:3.718 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site