lkml.org 
[lkml]   [2023]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/1] ice: Change assigning method of the CPU affinity masks
    On Thu, Feb 16, 2023 at 05:14:33PM +0200, Andy Shevchenko wrote:
    > On Thu, Feb 16, 2023 at 03:54:55PM +0100, Pawel Chmielewski wrote:

    ...

    > > + for_each_cpu_andnot(cpu, aff_mask, last_aff_mask) {
    > > + if (v_idx >= vsi->num_q_vectors)
    >
    > > + goto out;
    >
    > Useless. You can return 0; here.
    >
    > > + }

    Btw, I briefly checked the other functions nearby in the code and none of them
    is using goto for OK cases.


    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2023-03-27 00:25    [W:7.444 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site