Messages in this thread | | | Date | Thu, 16 Feb 2023 17:16:07 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 1/1] ice: Change assigning method of the CPU affinity masks |
| |
On Thu, Feb 16, 2023 at 05:14:33PM +0200, Andy Shevchenko wrote: > On Thu, Feb 16, 2023 at 03:54:55PM +0100, Pawel Chmielewski wrote:
...
> > + for_each_cpu_andnot(cpu, aff_mask, last_aff_mask) { > > + if (v_idx >= vsi->num_q_vectors) > > > + goto out; > > Useless. You can return 0; here. > > > + }
Btw, I briefly checked the other functions nearby in the code and none of them is using goto for OK cases.
-- With Best Regards, Andy Shevchenko
| |