lkml.org 
[lkml]   [2023]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 6/6] i2c: designware: Use PCI PSP driver for communication
    From
    On 2/10/23 00:38, Mario Limonciello wrote:
    > Currently the PSP semaphore communication base address is discovered
    > by using an MSR that is not architecturally guaranteed for future
    > platforms. Also the mailbox that is utilized for communication with
    > the PSP may have other consumers in the kernel, so it's better to
    > make all communication go through a single driver.
    >
    > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
    > ---
    > drivers/i2c/busses/Kconfig | 2 +-
    > drivers/i2c/busses/i2c-designware-amdpsp.c | 141 +-------------------
    > drivers/i2c/busses/i2c-designware-core.h | 1 -
    > drivers/i2c/busses/i2c-designware-platdrv.c | 1 -
    > include/linux/psp-platform-access.h | 1 +
    > 5 files changed, 9 insertions(+), 137 deletions(-)
    >
    > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
    > index a7bfddf08fa7b..9e2202ca73ec7 100644
    > --- a/drivers/i2c/busses/Kconfig
    > +++ b/drivers/i2c/busses/Kconfig
    > @@ -566,9 +566,9 @@ config I2C_DESIGNWARE_PLATFORM
    >
    > config I2C_DESIGNWARE_AMDPSP
    > bool "AMD PSP I2C semaphore support"
    > - depends on X86_MSR
    > depends on ACPI
    > depends on I2C_DESIGNWARE_PLATFORM
    > + depends on CRYPTO_DEV_SP_PSP && !(I2C_DESIGNWARE_PLATFORM=y && CRYPTO_DEV_CCP_DD=m)
    > help

    Would this look better if split? I.e.

    depends on CRYPTO_DEV_SP_PSP
    depends on !(I2C_DESIGNWARE_PLATFORM=y && CRYPTO_DEV_CCP_DD=m)

    \
     
     \ /
      Last update: 2023-03-27 00:25    [W:2.444 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site