Messages in this thread | | | Date | Thu, 16 Feb 2023 11:54:17 +0100 | Subject | Re: [PATCH 01/16] dt-bindings: PCI: Rename Exynos PCIe binding to Samsung PCIe | From | Krzysztof Kozlowski <> |
| |
On 14/02/2023 13:13, Shradha Todi wrote: > The current DT bindings is being used for Exynos5433 SoC only. > In order to extend this binding for all SoCs manufactured by > Samsung using DWC PCIe controller, renaming this file to a more > generic name.
Thank you for your patch. There is something to discuss/improve.
> > Signed-off-by: Shradha Todi <shradha.t@samsung.com> > --- > .../pci/{samsung,exynos-pcie.yaml => samsung,pcie.yaml} | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > rename Documentation/devicetree/bindings/pci/{samsung,exynos-pcie.yaml => samsung,pcie.yaml} (93%) > > diff --git a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml > similarity index 93% > rename from Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > rename to Documentation/devicetree/bindings/pci/samsung,pcie.yaml > index f20ed7e709f7..6cd36d9ccba0 100644 > --- a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml
We keep the name rather tied to compatible, not generic. There are no other compatibles here, so I don't think we should rename it.
Best regards, Krzysztof
| |