lkml.org 
[lkml]   [2023]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH v3 04/35] maple_tree: remove extra smp_wmb() from mas_dead_leaves()
    From
    From: Liam Howlett <Liam.Howlett@oracle.com>

    The call to mte_set_dead_node() before the smp_wmb() already calls
    smp_wmb() so this is not needed. This is an optimization for the RCU
    mode of the maple tree.

    Fixes: 54a611b60590 ("Maple Tree: add new data structure")
    Signed-off-by: Liam Howlett <Liam.Howlett@oracle.com>
    Signed-off-by: Suren Baghdasaryan <surenb@google.com>
    ---
    lib/maple_tree.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/lib/maple_tree.c b/lib/maple_tree.c
    index 44d6ce30b28e..3d5ab02f981a 100644
    --- a/lib/maple_tree.c
    +++ b/lib/maple_tree.c
    @@ -5517,7 +5517,6 @@ unsigned char mas_dead_leaves(struct ma_state *mas, void __rcu **slots,
    break;

    mte_set_node_dead(entry);
    - smp_wmb(); /* Needed for RCU */
    node->type = type;
    rcu_assign_pointer(slots[offset], node);
    }
    --
    2.39.1
    \
     
     \ /
      Last update: 2023-03-27 00:25    [W:4.061 / U:0.468 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site