Messages in this thread | | | Date | Wed, 15 Feb 2023 15:39:30 +0000 | From | Matthew Wilcox <> | Subject | Re: [PATCH v3 2/4] mm: change to return bool for isolate_lru_page() |
| |
On Wed, Feb 15, 2023 at 06:39:35PM +0800, Baolin Wang wrote: > The isolate_lru_page() can only return 0 or -EBUSY, and most users did > not care about the negative error of isolate_lru_page(), except one user > in add_page_for_migration(). So we can convert the isolate_lru_page() to > return a boolean value, which can help to make the code more clear when > checking the return value of isolate_lru_page(). > > Also convert all users' logic of checking the isolation state. > > No functional changes intended. > > Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com> > Acked-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
| |