Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 15 Feb 2023 14:24:01 +0100 | From | Neil Armstrong <> | Subject | Re: [PATCH] power: reset: odroid-go-ultra: fix I2C dependency |
| |
On 15/02/2023 13:47, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Since this driver can only be built-in, it fails to link when > the I2C layer is in a loadable module: > > x86_64-linux-ld: drivers/power/reset/odroid-go-ultra-poweroff.o: in function `odroid_go_ultra_poweroff_get_pmic_device': > odroid-go-ultra-poweroff.c:(.text+0x30): undefined reference to `i2c_find_device_by_fwnode' > > Tighten the dependency to only allow enabling > POWER_RESET_ODROID_GO_ULTRA_POWEROFF is I2C is built-in as well. > > Fixes: cec3b46b8bda ("power: reset: add Odroid Go Ultra poweroff driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for the fix !
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
> --- > drivers/power/reset/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > index 7059bd1f2ee7..8c87eeda0fec 100644 > --- a/drivers/power/reset/Kconfig > +++ b/drivers/power/reset/Kconfig > @@ -144,7 +144,7 @@ config POWER_RESET_OCELOT_RESET > config POWER_RESET_ODROID_GO_ULTRA_POWEROFF > bool "Odroid Go Ultra power-off driver" > depends on ARCH_MESON || COMPILE_TEST > - depends on I2C && OF > + depends on I2C=y && OF > help > This driver supports Power off for Odroid Go Ultra device. >
| ![\](/images/icornerr.gif) |