lkml.org 
[lkml]   [2023]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] soc: nuvoton: Fix Kconfig
    Hi Jonathan,

    On Sun, Feb 12, 2023 at 12:31 PM Jonathan Neuschäfer
    <j.neuschaefer@gmx.net> wrote:
    > Unfortunately, version 5 of the Nuvoton WPCM450 SoC driver was applied
    > to bmc.git, which misses a few fixes that were in version 6.
    >
    > This patch adds the missing fixes:

    Thanks for your patch!

    > - Add a menu "Nuvoton SoC drivers" to make it easier to add other
    > Nuvoton SoC drivers later on

    ... and to prevent asking about the Nuvoton WPCM450 SoC driver when
    configuring a kernel without support for Nuvoton SoCs.

    > - select CONFIG_REGMAP from CONFIG_WPCM450_SOC

    Please include why this is needed.

    >
    > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
    > Fixes: 77b8c67b5637 ("soc: nuvoton: Add SoC info driver for WPCM450")
    > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
    > ---
    > drivers/soc/nuvoton/Kconfig | 8 +++++++-
    > 1 file changed, 7 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/soc/nuvoton/Kconfig b/drivers/soc/nuvoton/Kconfig
    > index df46182088ec2..2167d3d739d84 100644
    > --- a/drivers/soc/nuvoton/Kconfig
    > +++ b/drivers/soc/nuvoton/Kconfig
    > @@ -1,11 +1,17 @@
    > # SPDX-License-Identifier: GPL-2.0
    > -menuconfig WPCM450_SOC
    > +menu "Nuvoton SoC drivers"
    > + depends on ARCH_NPCM || COMPILE_TEST
    > +
    > +config WPCM450_SOC
    > tristate "Nuvoton WPCM450 SoC driver"
    > default y if ARCH_WPCM450
    > select SOC_BUS
    > + select REGMAP
    > help
    > Say Y here to compile the SoC information driver for Nuvoton
    > WPCM450 SoCs.
    >
    > This driver provides information such as the SoC model and
    > revision.
    > +

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2023-03-27 00:19    [W:4.130 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site