Messages in this thread | | | Date | Thu, 7 Dec 2023 20:03:32 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next 05/15] net: dsa: mt7530: improve code path for setting up port 5 |
| |
On Sat, Dec 02, 2023 at 11:36:03AM +0300, Arınç ÜNAL wrote: > On 18.11.2023 17:41, Russell King (Oracle) wrote: > > > For the cases of PHY muxing or the port being disabled, call > > > mt7530_setup_port5() from mt7530_setup(). mt7530_setup_port5() from > > > mt753x_phylink_mac_config() won't run when port 5 is disabled or used for > > > PHY muxing as port 5 won't be defined on the devicetree. > > > > ... and this should state why this needs to happen - in other words, > > the commit message should state why is it critical that port 5 is > > always setup. > > Actually, port 5 must not always be setup. With patch 7, I explain this > while preventing mt7530_setup_port5() from running if port 5 is disabled. > > Arınç
Then change that last paragraph. You could say something like this:
To keep the cases where port 5 isn't controlled by phylink working as before, we need to preserve the mt7530_setup_port5() call from mt7530_setup().
I think it's a case of saying too much, which sparks too many unresolved questions in the reader's mind, which are irrelevant for the purpose of this specific change: eliminating the overlap between DSA's setup() time and phylink.
| |