lkml.org 
[lkml]   [2023]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 07/11] mm/mempolicy: add userland mempolicy arg structure
    On Thu, Dec 7, 2023, at 15:58, Gregory Price wrote:
    > On Thu, Dec 07, 2023 at 08:13:22AM +0100, Arnd Bergmann wrote:
    >> On Thu, Dec 7, 2023, at 01:27, Gregory Price wrote:
    >>
    >> Aside from this, you should avoid holes in the data structure.
    >> On 64-bit architectures, the layout above has holes after
    >> policy_node and after addr_node.
    >>
    >> Arnd
    >
    > doh, clearly i didn't stop to think about alignment. Good eye.
    > I'll redo this with __u/s members and fix the holes.
    >
    > Didn't stop to think about compat pointers. I don't think the
    > u64_to_user_ptr pattern is offensive, so i'll make that change.
    > At least I don't see what the other options are beyond compat.

    Ok, sounds good.

    I see you already call wrappers for compat mode to convert
    iovec and nodemask layouts for the indirect pointers, and they
    look correct. If you wanted to do handle the compat syscalls
    using the same entry point, you could add the same kind of
    helper to copy the mempolicy args from user space with an
    optional conversion, but not having to do this is clearly
    easier.

    Arnd

    \
     
     \ /
      Last update: 2023-12-07 16:43    [W:3.803 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site