lkml.org 
[lkml]   [2023]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH] thermal/debugfs: Add thermal debugfs information
From


On 12/6/23 21:43, Rafael J. Wysocki wrote:
> On Fri, Nov 10, 2023 at 8:37 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>

[snip]

>> diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
>> index 0a3b3ec5120b..809d37d0aa28 100644
>> --- a/drivers/thermal/thermal_core.h
>> +++ b/drivers/thermal/thermal_core.h
>> @@ -13,6 +13,7 @@
>> #include <linux/thermal.h>
>>
>> #include "thermal_netlink.h"
>> +#include "thermal_debugfs.h"
>>
>> /* Default Thermal Governor */
>> #if defined(CONFIG_THERMAL_DEFAULT_GOV_STEP_WISE)
>
> The change below is large and rather hard to grasp as a whole.
>
> It would be easier to process if it is split into a few smaller
> changes building on top of each other IMO.
>
> Personally, I would start with stubs of the functions that are called
> from the core and subsequently add more and more code to them.

I agree, for this approach for this patch. Also we implicitly agreed
that this CONFIG_THERMAL_DEBUG can fly upstream. What would be built
on top in the framework and in governors, could be developed in steps,
IMO.

Thanks for starting this debugfs support.

\
 
 \ /
  Last update: 2023-12-07 10:17    [W:0.084 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site