Messages in this thread | | | Date | Thu, 7 Dec 2023 14:13:32 +0530 | Subject | Re: [PATCH 11/13] scsi: ufs: qcom: Remove unused ufs_qcom_hosts struct array | From | Nitin Rawat <> |
| |
On 12/1/2023 8:44 PM, Manivannan Sadhasivam wrote: > ufs_qcom_hosts array is assigned, but not used anywhere. So let's remove > it. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > drivers/ufs/host/ufs-qcom.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index a86f6620abc8..824c006be093 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -90,8 +90,6 @@ static const struct __ufs_qcom_bw_table { > [MODE_MAX][0][0] = { 7643136, 307200 }, > }; > > -static struct ufs_qcom_host *ufs_qcom_hosts[MAX_UFS_QCOM_HOSTS]; > - > static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host *host); > static int ufs_qcom_set_core_clk_ctrl(struct ufs_hba *hba, bool is_scale_up); > > @@ -1192,9 +1190,6 @@ static int ufs_qcom_init(struct ufs_hba *hba) > > ufs_qcom_setup_clocks(hba, true, POST_CHANGE); > > - if (hba->dev->id < MAX_UFS_QCOM_HOSTS) > - ufs_qcom_hosts[hba->dev->id] = host; > - > ufs_qcom_get_default_testbus_cfg(host); > err = ufs_qcom_testbus_config(host); > if (err)
Hi Mani, There is plan to upstream 2nd UFS instance change which may need ufs_qcom_hosts. But for now this is unused and can be removed.
Anyways change Looks Good. Hence
Reviewed-by: Nitin Rawat <quic_nitirawa@quicinc.com>
Regards, Nitin
| |