Messages in this thread | | | Date | Thu, 7 Dec 2023 15:55:04 +0800 | Subject | Re: [PATCH v6 1/2] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl | From | Tengfei Fan <> |
| |
在 12/6/2023 5:04 PM, Krzysztof Kozlowski 写道: > On 06/12/2023 03:08, Tengfei Fan wrote: >> Add device tree binding Documentation details for Qualcomm SM4450 >> TLMM device. >> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- >> .../bindings/pinctrl/qcom,sm4450-tlmm.yaml | 151 ++++++++++++++++++ >> 1 file changed, 151 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml >> > > There was no reason to drop my review tag here. You did not explain why > it had to be dropped and changing indentation on example is for sure not > the case. > > Please read submitting-patches before posting new patches to mailing list. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof > Hi Krzysztof, I read submitting-patches.rst today. Like you said that I shouldn't drop your review tag due to change indentation. This is my fault. Thank you again for your patient reviw and explanation.
submitting-patches.rst: By offering my Reviewed-by: tag, I state that: (c) While there may be things that could be improved with this submission, I believe that it is, at this time, (1) a worthwhile modification to the kernel, and (2) free of known issues which would argue against its inclusion.
-- Thx and BRs, Tengfei Fan
| |