Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Jim Cromie <> | Subject | [re: PATCH v2 00/15 - 05/11] dyndbg: change +T:name_terminator to dot | Date | Thu, 7 Dec 2023 17:15:08 -0700 |
| |
This replaces ',' with '.' as the char that ends the +T:name.
This allows a later patch to treat ',' as a space, which mostly eliminates the need to quote query/rules. And this in turn avoids quoting hassles:
modprobe test_dynamic_debug dyndbg=class,D2_CORE,+p
It is particularly good for passing boot-args into test-scripts.
vng -p 4 -v \ -a test_dynamic_debug.dyndbg=class,D2_CORE,+p
Signed-off-by: Jim Cromie <jim.cromie@gmail.com> --- lib/dynamic_debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 2ac1bd7f105f..a5fc80edd24c 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -172,7 +172,7 @@ char *read_T_args(const char *str, struct flag_settings *modifiers) } str += 2; - end = strchr(str, ','); + end = strchr(str, '.'); if (end && *(end + 1) == '\0') return NULL; @@ -264,7 +264,7 @@ static char *ddebug_describe_ctrl(struct dd_ctrl *ctrl, struct ctrlbuf *cb) for (i = 0; i < ARRAY_SIZE(opt_array); ++i) if (ctrl->flags & opt_array[i].flag) { if (show_args) - *p++ = ','; + *p++ = '.'; *p++ = opt_array[i].opt_char; show_args = opt_array[i].show_args; if (show_args) -- 2.43.0
| ![\](/images/icornerr.gif) |