lkml.org 
[lkml]   [2023]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 4/4] serial: 8250: Add preferred console in serial8250_isa_init_ports()
* Andy Shevchenko <andriy.shevchenko@intel.com> [231205 16:08]:
> On Tue, Dec 05, 2023 at 09:32:36AM +0200, Tony Lindgren wrote:
> > + name = kasprintf(GFP_KERNEL, "%s%i", serial8250_reg.dev_name, idx);
>
> No error check?

Oops

> > + ret = add_preferred_console_match(name, serial8250_reg.dev_name, idx);
> > + if (!ret || ret == -ENOENT)
> > + return;
>
> ret = serial_base_add_one_prefcon(...);
>
> ?

Yup that should work even before struct device. Will fix the other
places too you noticed.

Thanks,

Tony

\
 
 \ /
  Last update: 2023-12-07 08:24    [W:1.275 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site