Messages in this thread | ![/](/images/icornerl.gif) | | From | Andrii Nakryiko <> | Date | Mon, 4 Dec 2023 20:05:27 -0800 | Subject | Re: [PATCH bpf-next v4 06/10] libbpf: selftests: Add verifier tests for CO-RE bitfield writes |
| |
On Mon, Dec 4, 2023 at 12:57 PM Daniel Xu <dxu@dxuuu.xyz> wrote: > > Add some tests that exercise BPF_CORE_WRITE_BITFIELD() macro. Since some > non-trivial bit fiddling is going on, make sure various edge cases (such > as adjacent bitfields and bitfields at the edge of structs) are > exercised. > > Acked-by: Andrii Nakryiko <andrii@kernel.org> > Signed-off-by: Daniel Xu <dxu@dxuuu.xyz> > ---
nit: please drop "libbpf: " prefix from the patch subject, this is "selftests/bpf: " actually
> .../selftests/bpf/prog_tests/verifier.c | 2 + > .../bpf/progs/verifier_bitfield_write.c | 100 ++++++++++++++++++ > 2 files changed, 102 insertions(+) > create mode 100644 tools/testing/selftests/bpf/progs/verifier_bitfield_write.c >
[...]
| ![\](/images/icornerr.gif) |