Messages in this thread Patch in this message |  | | From | Lin Ma <> | | Subject | [PATCH v1] RDMA/sa_query: use validate not parser in ib_nl_is_good_resolve_resp | | Date | Sat, 30 Dec 2023 13:19:56 +0800 |
| |
The attributes array `tb` in ib_nl_is_good_resolve_resp is never used after the parsing. Therefore use nla_validate_deprecated function here for improvement.
Signed-off-by: Lin Ma <linma@zju.edu.cn> --- drivers/infiniband/core/sa_query.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/core/sa_query.c b/drivers/infiniband/core/sa_query.c index 8175dde60b0a..c7407a53fcda 100644 --- a/drivers/infiniband/core/sa_query.c +++ b/drivers/infiniband/core/sa_query.c @@ -1047,14 +1047,13 @@ int ib_nl_handle_set_timeout(struct sk_buff *skb, static inline int ib_nl_is_good_resolve_resp(const struct nlmsghdr *nlh) { - struct nlattr *tb[LS_NLA_TYPE_MAX]; int ret; if (nlh->nlmsg_flags & RDMA_NL_LS_F_ERR) return 0; - ret = nla_parse_deprecated(tb, LS_NLA_TYPE_MAX - 1, nlmsg_data(nlh), - nlmsg_len(nlh), ib_nl_policy, NULL); + ret = nla_validate_deprecated(nlmsg_data(nlh), nlmsg_len(nlh), + LS_NLA_TYPE_MAX - 1, ib_nl_policy, NULL); if (ret) return 0; -- 2.17.1
|  |