Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 27 Dec 2023 16:33:37 +0200 | From | Petre Rodan <> | Subject | Re: [PATCH v2 08/10] iio: pressure: mprls0025pa.c refactor |
| |
Hi Jonathan,
On Tue, Dec 26, 2023 at 04:49:22PM +0000, Jonathan Cameron wrote: > > if (data->irq > 0) { > > ret = devm_request_irq(dev, data->irq, mpr_eoc_handler, > > - IRQF_TRIGGER_RISING, client->name, data); > > + IRQF_TRIGGER_RISING, dev_name(dev), data); > > Even though you'll change it again here, would have been nice to have > the alignment fixed in the earlier patch then the code update here.
I tried this, but due to the fact that the line has to be right-aligned to column 80 we will still see a whitespace difference due to the length diff of the name-related argument.
> > +++ b/drivers/iio/pressure/mprls0025pa_i2c.c > > + > > +#include <linux/iio/iio.h> > > Why include this? Can't see an IIO specific stuff in here.
tried to remove it and
CC [M] mprls0025pa_i2c.o mprls0025pa.h:89:63: error: 'IIO_DMA_MINALIGN' undeclared here (not in a function); did you mean 'ARCH_DMA_MINALIGN'? 89 | u8 buffer[MPR_MEASUREMENT_RD_SIZE] __aligned(IIO_DMA_MINALIGN);
I guess it makes more sense to move it to the .h file, where buffer[] is defined.
everything else will be fixed as per your feedback.
thanks, peter
-- petre rodan [unhandled content-type:application/pgp-signature]
| ![\](/images/icornerr.gif) |