| Date | Wed, 27 Dec 2023 12:54:43 +0100 | | Subject | Re: [PATCH v3 07/24] ARM: dts: samsung: exynos5420: Enable cros-ec-spi as wake source | | From | Krzysztof Kozlowski <> |
| |
On 26/12/2023 20:21, Mark Hasemeyer wrote: > The cros_ec driver currently assumes that cros-ec-spi compatible device > nodes are a wakeup-source even though the wakeup-source property is not > defined. > > Some Chromebooks use a separate wake pin, while others overload the > interrupt for wake and IO. With the current assumption, spurious wakes > can occur on systems that use a separate wake pin. It is planned to > update the driver to no longer assume that the EC interrupt pin should > be enabled for wake. > > Add the wakeup-source property to all cros-ec-spi compatible device > nodes to signify to the driver that they should still be a valid wakeup > source. > > -Commit-changes: 3
This looks like changelog, although a bit confusing. If it is changelog, then please keep it under ---.
I can fix it while applying, but this will be after the merge window.
Best regards, Krzysztof
|